4.0.0 multi router #2719
Closed
4.0.0 multi router #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enes declared above - Enhancement: If component has static navigationOptions return it instead of RNRF generated options - Enhancement: Allow all navBar properties (title, right, left, rightButtonImage, onRight, etc.) be defined as static functions/values of Scene component - Fix: Actions.refresh was broken because navigationStore doesn’t allow the same scene after state change - Enhancement: fix ESLint errors for tests
PR for beta.8
- Enhancement: support inheritance of scene props (useful for `headerMode` attribute for different RN StackNavigator animation) - Fix: attempt to fix react-navigation pushes instead of jumping when user taps the same tab (aksonov#2024) - Enhancement: use navBarButtonColor or tintColor or headerTintColor for image button tintcolor (aksonov#2028) - Fix: use backBehavior='initialRoute' by default (aksonov#2026) - Enhancement: allow right/leftTitle, right/leftButtonImage to be static functions within scene component - Enhancement: allow wrapping all screens and navbar buttons with `wrapBy` parameter for `Router`. It could be `observer` from MobX, or `connect` from Redux or any other function. - Fix: eslint formatting, fix CircleCI build
fix: tintColor doesn't work for back/left button
* v4 docs * more docs
Add API documentation for onBack prop
Update API.md
add "wrapBy" to RouterProps
…react (aksonov#2584) * upd deps * upd pkgs * upd RN to fix test * upd mobx & mobx-react
Update link for open issues
Update link for open issues in CONTRIBUTING.md
document Tabs animationEnabled property documentation
* Deep linking draft (doesn't work properly yet) * fix build * fix errors
…nov#2605) Significant change is that TabProps no longer extend SceneProps, as Tabs do not need to have a component set. Was unable to add which properties should be inherited from SceneProps to TabProps due to the fact that there is no code in Tabs.js
* Adds universal linking with parameter parsing * Adds universal linking with parameter parsing * Adds universal linking with parameter parsing * yarn lock * linting * changes reflected in dist
|
Sorry for the delay, we were working on upgrade RNRF to latest React Navigation (2.x). If you still want to have this functionality, please apply new PR for new version (beta.40) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple router is very useful for some project ,especially hybrid app when native code want to start different RN component at different page but using same RCTBridge.
For now(4.0.0-beta.24), multiple router in RNRF is not supported yet, so I wrote some code try to enhance it, and I also mentioned that other guys could need this feature like #2274
So, this PR is sent. hopefully helpful.
I also wrote a demo to demonstrate how to use multiple router in hybrid app ,check it out
https://github.com/brrr/example_RNFR_MULTI_ROUTER