Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): add missing properties and in general fix typings #2605

Merged
merged 2 commits into from
Nov 9, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type Router = RouterStatic;
export var Reducer: any;
export type Reducer = any;

// Router
// Router
interface RouterProps extends React.Props<Router> {
sceneStyle?: StyleProp<ViewStyle>;
backAndroidHandler?: Function;
Expand Down Expand Up @@ -90,7 +90,7 @@ interface TabsProps extends React.Props<Tabs> {
tabBarOnPress?: function;
backToInitial?: boolean;
}
interface TabsStatic extends React.ComponentClass<SceneProps & TabsProps> { }
interface TabsStatic extends React.ComponentClass<TabsProps> { }
export type TabBarPositionType = "top" | "bottom";

// Drawer
Expand All @@ -116,7 +116,7 @@ export type Overlay = OverlayStatic;
interface OverlayProps extends React.Props<Overlay> { }
interface OverlayStatic extends React.ComponentClass<SceneProps & OverlayProps> { }

// Lightbox
// Lightbox
export var Lightbox : LightboxStatic;
export type Lightbox = LightboxStatic;
interface LightboxProps extends React.Props<Modal> { }
Expand All @@ -125,13 +125,18 @@ interface LightboxStatic extends React.ComponentClass<LightboxProps> { }
// Stack
export var Stack: StackStatic;
export type Stack = StackStatic;
interface StackProps extends React.Props<Stack> {

interface StackProps extends React.Props<Stack> {
navigationBarStyle?: StyleProp<ViewStyle>;
icon?: any;
tintColor?: string;
hideNavBar?: boolean;
}
interface StackStatic extends React.ComponentClass<StackProps> {
}
interface StackStatic extends React.ComponentClass<StackProps> { }

export var Actions: ActionsStatic & ActionsGenericStatic;
export type Actions = ActionsStatic & ActionsGenericStatic;
export var Actions: ActionsGenericStatic;
export type Actions = ActionsGenericStatic;
interface ActionsStatic {
currentScene: string;
jump: (sceneKey: string, props?: any) => void;
Expand All @@ -146,7 +151,7 @@ interface ActionsStatic {
drawerClose?: () => void;

}
interface ActionsGenericStatic {
interface ActionsGenericStatic extends ActionsStatic {
[key: string]: (props?: any) => void;
}

Expand Down