Whitelist event listeners to prevent "scene 'on...' is not defined" warning #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesha-antonov
changed the title
kesha-antonov
changed the title
|
Hey. Could you remove package-lock from this PR, please? |
|
Why? It's not in gitignore and it's good practice to keep .lock files. |
|
Sure, but we use yarn (also for this). You can add package-lock to gitignore in commit if you want :) |
|
Please check latest master now. I fixed it in different way because you PR would break other functionality (like custom transition shortcuts like onLogin='loginScene') |
|
Ok. Thanks! @aksonov |
mvanroon
pushed a commit
to mvanroon/react-native-router-flux
that referenced
this pull request
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When I open a scene with
Actions.scene({ onUpdateSmth: this.myFunc })orActions.scene({ onUpdateSmth: undefined })I getscene "onUpdateSmth" is not defined.We should use whitelist for events that starts with
on.