-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide navbar programmatically #2492
Conversation
please merge |
Can you just check Example project with your PR? You will see no drawer button there after 'go to tabbar page', sorry, I can't merge and break this. just replace
to
within |
Fine. So please have a look at the last update. There was a problem with hiding UPD: Hmm, nope, there is still some problems with hiding NavBar in some cases (for example with tabs). |
Yes, it still has problems - just tap "next screen for tab2_1" and you will not see "back" nav button. |
@onrige Please check latest master, I hope I fixed that issue and your code to Example/navigationStore. Feel free to reopen if you have any bugs. |
If I want to hide hideTabBar, the first success, the second failed.
|
According to this issue #2441 and this commit (2909046) I am adding this functionallity again. I was trying to catch the issue when NavBar was hiding inside Drawer but I didn't succeed. May be I don't know something but according to the React Navigation docs it's not possible to put NavBar inside Drawer. @aksonov could you provide more detailed example for me to catch this error? As I said in commit comment - there are a lot of people that need this functionality so we need to resolve this problem.