Initial attempt at project typings #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
mvanroon
pushed a commit
to mvanroon/react-native-router-flux
that referenced
this pull request
Feb 15, 2018
* Initial attempt at project typings. Would we prefer a push to DefinitelyTyped? aksonov#2273 * Need to add react and react-native types to dev dependencies. aksonov#2273 * Added support for ActionConst. aksonov#2273 * Clean up of react types to support classes and sfc's, as well as better style support
|
@jatsrt I've noticed that you have added an extra commit in your fork - is that complementing the TS support? Do you mind creating a new PR for it? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an initial attempt at adding typings to the project. This could also be done as part of DefinitelyTyped instead. However I saw this thread and figured I'd help it along.
#2273