Fixed popTo method #2179
Merged
Fixed popTo method #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popTo method used to fail in case there were a Scene in the stack of the same kind of the current one.
|
@ulentini I have the following situation: [A, B, B, B, C, D] "B" is actually may "app controller" which does different things based on different props. I want to pop to the 1st "B" state. How can I use the Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
popTo()method used to fail in case there were a Scene in the stack of the same kind of the current one.How to reproduce it
Let's assume we have a navigation stack with the following Scenes:
[A, B, C, C](being A the root Scene, C the current Scene).Calling
popTo('A')orpopTo('B')would fail, because ofnextScene !== currentScenewithin thewhilecondition. Removing that condition solved the problem.