Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-addons-pure-render-mixin #1790

Closed
wants to merge 1 commit into from
Closed

remove react-addons-pure-render-mixin #1790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
}
],
"dependencies": {
"react-addons-pure-render-mixin": "15.0.2",
"react-native-experimental-navigation": "0.26.x",
"react-native-tabs": "^1.0.9",
"react-static-container": "1.0.1"
Expand Down
6 changes: 2 additions & 4 deletions src/DefaultRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*
*/
import React, {
Component,
PureComponent,
PropTypes,
} from 'react';
import {
Expand All @@ -22,7 +22,6 @@ import NavBar from './NavBar';
import Actions from './Actions';
import { deepestExplicitValueForKey } from './Util';
import NavigationExperimental from 'react-native-experimental-navigation';
import PureRenderMixin from 'react-addons-pure-render-mixin';

const SCREEN_WIDTH = Dimensions.get('window').width;

Expand Down Expand Up @@ -99,7 +98,7 @@ function leftToRight(/* NavigationSceneRendererProps */ props) {
};
}

export default class DefaultRenderer extends Component {
export default class DefaultRenderer extends PureComponent {

static propTypes = {
navigationState: PropTypes.object,
Expand All @@ -113,7 +112,6 @@ export default class DefaultRenderer extends Component {
constructor(props) {
super(props);

this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this);
this.renderCard = this.renderCard.bind(this);
this.renderScene = this.renderScene.bind(this);
this.renderHeader = this.renderHeader.bind(this);
Expand Down