Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Actions.replace() and Actions.reset() animated transition is happening #3741

Open
kolarus opened this issue Mar 19, 2021 · 15 comments
Open

Comments

@kolarus
Copy link

kolarus commented Mar 19, 2021

Version

  • react-native-router-flux v4.3.0
  • react-native v0.63.4
  • react: 16.13.1

Expected behaviour

When using Actions.replace() or Actions.reset() no animated transition should occur

Actual behaviour

Animated transition happens

Platform

IOS (Not tested on android yet)

@oleksandr-dziuban
Copy link

Same issues after migration to 4.3.0 from 4.2.0, @aksonov Could you please check? Thanks!

@aksonov
Copy link
Owner

aksonov commented Mar 24, 2021

Please check latest master

@oleksandr-dziuban
Copy link

oleksandr-dziuban commented Mar 25, 2021

Please check latest master

Great, thanks, could you please deploy fix to latest npm package?

@minuitagency
Copy link

Hi @aksonov , thank you for the quick fix, I still have a transition animation when using Actions.reset() in 4.3.1, is there something I missed or a dependency that I should update?

Thanks

@aksonov
Copy link
Owner

aksonov commented Mar 26, 2021 via email

@minuitagency
Copy link

@aksonov just checked your code, the "type" prop was undefined that's why the animation loaded, I patched it with:

animationEnabled: (type === ActionConst.REPLACE || type === 'replace' || !type) ? false : true,

It works for me now

@aksonov
Copy link
Owner

aksonov commented Mar 26, 2021

Hm, this will broke 'push' type animations..

@minuitagency
Copy link

oh... what should I do? Why is "type" undefined ?

@Yhnlvy
Copy link

Yhnlvy commented Mar 26, 2021

Following

@aksonov
Copy link
Owner

aksonov commented Mar 26, 2021 via email

@kolarus kolarus closed this as completed May 12, 2021
@oleksandr-dziuban
Copy link

oleksandr-dziuban commented May 12, 2021

@aksonov Hello, issue still exists, are you planning to resolve it and deploy new patch version? Thansk a lot

@kolarus
Copy link
Author

kolarus commented May 12, 2021

Reopening, just checked, we still have animations

@kolarus kolarus reopened this May 12, 2021
@ebaynaud
Copy link

@pacoyang
Copy link

pacoyang commented Jun 2, 2021

Same issue on 4.3.1

@yogendrajs
Copy link

The issue still persists, does someone have an idea how to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants