Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header title not centered when there is a right/left button #3153

Closed
mdelclaro opened this issue Jul 30, 2018 · 8 comments
Closed

Header title not centered when there is a right/left button #3153

mdelclaro opened this issue Jul 30, 2018 · 8 comments
Assignees
@daviscabral
Labels
android Specific to Android backwards-incompatible Breaking changes enhancement

Comments

@mdelclaro
Copy link

Version

Tell us which versions you are using:

Expected behaviour

Header title to be centered

Actual behaviour

image
@aksonov
Copy link
Owner

aksonov commented Aug 8, 2018

Please check latest version based on react navigation 2.x - 4.0.0-beta.40

@aksonov
Copy link
Owner

aksonov commented Aug 8, 2018

Android maintainer is really wanted, I'm using iOS right now.

@daviscabral
Copy link
Collaborator

I am back on Android - most of my users are Android. Now I am with several AVDs on my mac to test - so I can help with that.

@aksonov
Copy link
Owner

aksonov commented Aug 8, 2018

@daviscabral Great. Hopefully I solved the non-trivial problem withpopTo and also restored reducer support, so please check beta.40 and let's close all issues now ;)

@MattyK14
Copy link

MattyK14 commented Aug 9, 2018 •
edited
Loading

Seems the header is no longer centered after upgrading to [email protected]. Tested with beta.42 & beta.31. beta.31 is fine on [email protected] whereas beta.42 just doesn't run, both are off center on [email protected].

screenshot_1533829160

@aksonov
Copy link
Owner

aksonov commented Aug 9, 2018

So what is expected/actual (RN0.55)?

@MattyK14
Copy link

MattyK14 commented Aug 9, 2018 •
edited
Loading

Expected (seen on RN 0.54 & previous versions):

screen shot 2018-08-09 at 1 23 05 pm

Actual (seen on RN 0.55):

screenshot_1533829160

Only observed on Android, not present on iOS.

@aksonov aksonov mentioned this issue Sep 6, 2018
Closed
daviscabral added a commit that referenced this issue Sep 12, 2018
@daviscabral
Closes #3153: Bring headerLayoutPreset and headerBackTitleEnabled fro…
7457d67 
…m RN
@daviscabral daviscabral mentioned this issue Sep 12, 2018
Merged
@daviscabral
Copy link
Collaborator

Fixed on #3256.

Image from Gyazo

aksonov pushed a commit that referenced this issue Sep 13, 2018
@daviscabral @aksonov
Closes #3153: Bring headerLayoutPreset and headerBackTitleEnabled fro…
8d86709 
…m RN (#3256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviscabral daviscabral

Labels
android Specific to Android backwards-incompatible Breaking changes enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daviscabral @aksonov @MattyK14 @mdelclaro