-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-native-router-flux v4.0.0-beta.27/npm module]PopTo method is not fixed #2799
Comments
|
@Blapi I try that, didn't work,so I dowloaded the package,codes are still differences |
@sharkrice, just upgraded from 0.24 to 0.27 and looks like you're right, I've got the same issue. @aksonov, could you have a look on this please? |
@Blapi Published 0.28, could you check? |
@aksonov just upgraded and everything looks fine ! @sharkrice closing this as it's solved, upgrade your RNRF version properly to 0.28 |
@Blapi @aksonov
So I copied node_modules\react-native-router-flux outside and builded it, and then i copied new I cleared cache and deleted node_modules folder several times, it always happens. My Computer OS is WIN 10. |
Yeah same for me, I downgraded to 0.24 because it is enough stable for me and I'm in a hurry but yep, I also have these issues as well as some The @aksonov I guess @sharkrice gave the good fix? |
@Blapi Same issue on Android with react-native-router-flux 4.0.0-beta.28 How far do I need to rollback to avoid? react-native-router-flux 4.0.0-beta.24 ?
On attempt to switch to this scene with type="replace"
Android:
|
Yeah I'm now using .27 because .28 is broken with this. This one is stable, be careful to put But then, considering the original issue, not sure if this will help you |
Had the same bug on |
Looks like we need to revert related commits...
… On 6 Feb 2018, at 11:10, Facundo Acosta ***@***.***> wrote:
Had the same bug on 4.0.0-beta.28 when using Actions.replace('screen'). Downgrading to 4.0.0-beta.27 fixed it but the last version is broken. @kesha-antonov <https://github.com/kesha-antonov>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2799 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcR1pD95PlcroPWXydMm95p5vhl36ks5tSCUcgaJpZM4RfI38>.
|
@Blapi and @FacuAcosta Thank you. I also confirm 4.0.0-beta.27 does not crash on
|
Beta 27 and 28 are crashing for me with the aforementioned error. |
Note: I also use REDUX through connected components and works on 0.24 (but I cannot use "onExit" which I really need to use in order to clear a timer and this can be done only in 0.28.... but I cannot use this either). |
Same problem here with beta 28 im getting:
when doing this:
Im using redux too, now i've just download the beta 26 version that has the react-navigation version fixed, could you please check at this too? #2865 because if we need to go for the beta 24 version for using redux we need to use the fixed version of react-navigation, i mean:
instead of
kind regards |
in 0.27 the PopTo method is not fixed and then in 0.28 the replace breaks... |
Hey guys! https://github.com/react-navigation/react-navigation/releases react-navigation 1.0 was released. Maybe it has been fixed there! |
i have tried RNRF beta 28 with react nativation 1.0.0 but im having troubles with the redux, same problem as my last comment here.. TypeError: undefined is not an object (evaluating 'resetAction.actions.map') is this an issue with 1.0.0 version of react-navigation or RNRF doesnt provide support for this new release? Because the RNRF beta 28 version uses 1.0.0-beta.22 version of react-navigation .. |
Also getting: TypeError: undefined is not an object (evaluating 'resetAction.actions.map') With 24, 27 and 28. |
Here work only type: "replace" in beta 27 |
Thanks guys |
Today, latest version 4.0.0-beta.28 is not working, Beta 27 is working. Anybody can look into it? with new newbie that's really challenge. |
I am getting the same error on beta27. The scene is like this
And I have a function for navigation like this
or when I am using it like this Actions.replace('myScreen') then also I get the same error. |
The error occurs on beta 28, but beta 27 works fine. |
Version
react-native-router-flux v4.0.0-beta.27
Actual behaviour
if stack has same scenes as your current scenes, popTo doesn't pop back
Fixed popTo method (again)
However...
Left pic is react-native-router-flux npm module's source code
Right pic is source code on github
Their version numbers are both v4.0.0-beta.27, but codes are differences
The text was updated successfully, but these errors were encountered: