Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native-router-flux v4.0.0-beta.27/npm module]PopTo method is not fixed #2799

Closed
sharkrice opened this issue Jan 16, 2018 · 24 comments
Closed
Labels

Comments

@sharkrice
Copy link

Version

react-native-router-flux v4.0.0-beta.27

Actual behaviour

if stack has same scenes as your current scenes, popTo doesn't pop back

Fixed popTo method (again)

However...
Left pic is react-native-router-flux npm module's source code
Right pic is source code on github

???

Their version numbers are both v4.0.0-beta.27, but codes are differences
They are both v4.0.0-beta.27

@Blapi
Copy link
Collaborator

Blapi commented Jan 16, 2018

rm -rf node_modules
yarn cache clean
yarn install

@sharkrice
Copy link
Author

sharkrice commented Jan 16, 2018

@Blapi I try that, didn't work,so I dowloaded the package,codes are still differences
https://registry.npmjs.org/react-native-router-flux/-/react-native-router-flux-4.0.0-beta.27.tgz

@Blapi
Copy link
Collaborator

Blapi commented Jan 16, 2018

@sharkrice, just upgraded from 0.24 to 0.27 and looks like you're right, I've got the same issue.

@aksonov, could you have a look on this please?

@aksonov
Copy link
Owner

aksonov commented Jan 16, 2018

@Blapi Published 0.28, could you check?

@Blapi
Copy link
Collaborator

Blapi commented Jan 16, 2018

@aksonov just upgraded and everything looks fine !

@sharkrice closing this as it's solved, upgrade your RNRF version properly to 0.28

@Blapi Blapi closed this as completed Jan 16, 2018
@sharkrice
Copy link
Author

@Blapi @aksonov
another strange problem, i upgrade my RNRF to 0.28, but React Native throw an error

[mobx] Encountered an uncaught exception that was thrown by a reaction or observer component, in: 'Reaction[Autorun@10]
ExceptionsManager.js:73
TypeError: Cannot read property 'map' of undefined
ExceptionsManager.js:73
Cannot read property 'map' of undefined

So I copied node_modules\react-native-router-flux outside and builded it, and then i copied new dist to node_modules\react-native-router-flux overwrite old dist folder, and then it fixed, react-native didn't throw error.

I cleared cache and deleted node_modules folder several times, it always happens.

My Computer OS is WIN 10.

@Blapi
Copy link
Collaborator

Blapi commented Jan 18, 2018

Yeah same for me, I downgraded to 0.24 because it is enough stable for me and I'm in a hurry but yep, I also have these issues as well as some Illegal invocation warnings.

The TypeError: Cannot read property 'map' of undefined appeared for me because of the type='replace' in my scenes

@aksonov I guess @sharkrice gave the good fix?

@esutton
Copy link

esutton commented Jan 31, 2018

@Blapi Same issue on Android with react-native-router-flux 4.0.0-beta.28

How far do I need to rollback to avoid?

react-native-router-flux 4.0.0-beta.24 ?

TypeError: undefined is not an object (evaluating 'resetAction.actions.map')

On attempt to switch to this scene with type="replace"

            <Scene
              key={scene.Key.WaypointScreenParentAddNew}
              component={props => (
                <WaypointScreenParent {...props} {...this.props} />
                )}
              type="replace"
              hideNavBar={false}
              hideTabBar={false}
            />

Android:

		"react": "^16.2.0",
		"react-native": "^0.51.0",
		"react-native-router-flux": "^4.0.0-beta.28",

@Blapi
Copy link
Collaborator

Blapi commented Feb 1, 2018

Yeah I'm now using .27 because .28 is broken with this. This one is stable, be careful to put
"react-native-router-flux": "4.0.0-beta.27" and not
"react-native-router-flux": "^4.0.0-beta.27"

But then, considering the original issue, not sure if this will help you

@facuacostag
Copy link

Had the same bug on 4.0.0-beta.28 when using Actions.replace('screen'). Downgrading to 4.0.0-beta.27 fixed it but the last version is broken. @kesha-antonov

@aksonov
Copy link
Owner

aksonov commented Feb 6, 2018 via email

@esutton
Copy link

esutton commented Feb 6, 2018

@Blapi and @FacuAcosta Thank you.

I also confirm 4.0.0-beta.27 does not crash on Actions.replace('screen')

yarn remove react-native-router-flux
yarn add [email protected]

@mvanroon
Copy link
Contributor

mvanroon commented Feb 7, 2018

Beta 27 and 28 are crashing for me with the aforementioned error.
Beta 26 is working.

@afilp
Copy link

afilp commented Feb 7, 2018

Note: I also use REDUX through connected components and works on 0.24 (but I cannot use "onExit" which I really need to use in order to clear a timer and this can be done only in 0.28.... but I cannot use this either).

@marcosmartinez7
Copy link

Same problem here with beta 28

im getting:

TypeError: undefined is not an object (evaluating 'resetAction.actions.map')

when doing this:

Actions[this.props.targetScene].call()
where targetScene is just the scene to redirect

Im using redux too, now i've just download the beta 26 version that has the react-navigation version fixed, could you please check at this too? #2865

because if we need to go for the beta 24 version for using redux we need to use the fixed version of react-navigation, i mean:

"react-navigation": "1.0.0-beta.22"

instead of

"react-navigation": "^1.0.0-beta.19" (this willl result in 1.0.0 nowadays)

kind regards

@Ekhui
Copy link

Ekhui commented Feb 8, 2018

in 0.27 the PopTo method is not fixed and then in 0.28 the replace breaks...

@kesha-antonov
Copy link
Contributor

Hey guys! https://github.com/react-navigation/react-navigation/releases

react-navigation 1.0 was released. Maybe it has been fixed there!
Could you check it?

@marcosmartinez7
Copy link

marcosmartinez7 commented Feb 8, 2018

i have tried RNRF beta 28 with react nativation 1.0.0 but im having troubles with the redux, same problem as my last comment here..

TypeError: undefined is not an object (evaluating 'resetAction.actions.map')

is this an issue with 1.0.0 version of react-navigation or RNRF doesnt provide support for this new release? Because the RNRF beta 28 version uses 1.0.0-beta.22 version of react-navigation ..

@curliq
Copy link

curliq commented Feb 10, 2018

Also getting:

TypeError: undefined is not an object (evaluating 'resetAction.actions.map')

With 24, 27 and 28.

@famadori
Copy link

famadori commented Feb 11, 2018

Here work only type: "replace" in beta 27

@chaipipatP
Copy link

chaipipatP commented Feb 15, 2018

Thanks guys
Beta 27 is working

@bachphuc
Copy link

Today, latest version 4.0.0-beta.28 is not working, Beta 27 is working. Anybody can look into it? with new newbie that's really challenge.

@aayushis12
Copy link

aayushis12 commented Apr 23, 2018

I am getting the same error on beta27. The scene is like this

<Scene
                  key="myScreen"
                  component={screen}
                  initial
                />

And I have a function for navigation like this

onPress={() => Actions.myScreen({ type: ActionConst.REPLACE })

or when I am using it like this Actions.replace('myScreen') then also I get the same error.

@mkhuda
Copy link

mkhuda commented May 4, 2018

The error occurs on beta 28, but beta 27 works fine.
TypeError: Cannot read property 'map' of undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests