Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'string' of undefined #2517

Closed
sutefan1 opened this issue Oct 17, 2017 · 9 comments
Closed

Cannot read property 'string' of undefined #2517

sutefan1 opened this issue Oct 17, 2017 · 9 comments

Comments

@sutefan1
Copy link

Version

These are my dependencies:
"dependencies": {
"firebase": "^4.5.0",
"prop-types": "^15.6.0",
"react": "^16.0.0",
"react-native": "0.49.3",
"react-native-router-flux": "^3.26.22",
"react-native-router-redux": "^0.2.2",
"react-redux": "^5.0.6",
"redux": "^3.7.2",
"redux-thunk": "^2.2.0"

I tested it with "react-native-router-flux": "^4" too, but same behaviour.

Expected behaviour

Show component with router header.

Actual behaviour

simulator screen shot - iphone 6 - 2017-10-17 at 17 05 09

Click on " Scene.js:23:2" shows up this file:
screen shot 2017-10-17 at 17 06 50

Steps to reproduce

Codesnippet should explain enough:
const RouterComponent = () => ( <Router> <Scene key="login" component={LoginForm} tabTitle="Login" /> </Router> );
PS: tested "tabTitle" and "title", but the error is the same.

@mvanroon
Copy link
Contributor

mvanroon commented Oct 18, 2017

have you tried upgrading RNRF?

@sutefan1
Copy link
Author

sutefan1 commented Oct 18, 2017 via email

@sutefan1
Copy link
Author

@mvanroon Still there with [email protected].
If I try Text.proptypes.string instead of PropTypes.string in Scene.js, it doesn't crash in TabbedView, but in NavigationContainer.js.

@sutefan1
Copy link
Author

It's working at version 3.41.0 after replace the deprecated PropTypes import from React to prop-types everywhere it crashes.

@mvanroon
Copy link
Contributor

Try upgrading to v4.x and see if the issue still persists.
Please bear in mind that GitHub is not the place the ask questions about old versions of RNRF.
I recommend asking your question on stackoverflow.com. Make sure you add the react-native-router-flux label

@sutefan1
Copy link
Author

@mvanroon Ok, next time I'll ask it there.
I upgraded to 4.0.0-beta.22, but then I got this error.
simulator screen shot - iphone 6 - 2017-10-19 at 13 24 52

@mvanroon
Copy link
Contributor

Post your problem on stackoverflow along with your code and I'll have a look.

@aksonov could you close this issue please?

@miuel
Copy link

miuel commented Oct 23, 2017

Hello @papsti7 did you finally solve ? I have same problem in this versions:
"react": "16.0.0-beta.5",
"react-native": "0.49.3",
"react-native-router-flux": "^3.35.0",

@mak12
Copy link

mak12 commented Mar 5, 2020

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants