Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested scenes in v4? #2220

Closed
pukhalski opened this issue Aug 11, 2017 · 8 comments
Closed

Nested scenes in v4? #2220

pukhalski opened this issue Aug 11, 2017 · 8 comments

Comments

@pukhalski
Copy link

Version

react-native-router-flux v4.0.0-beta.16
react-native v0.46.4

Expected behaviour

Be able to use a Scene to wrap another scenes with some background image/video.

Actual behaviour

No availability.

Steps to reproduce

<Scene key="wrapper" component={BackgroundImage}
  <Scene key="scene1" component={Component1} />
  <Scene key="scene2" component={Component2} />
  <Scene key="scene3" component={Component3} />
</Scene>
<Scene key="scene4" component={Component4} />
@dvvtms
Copy link

dvvtms commented Aug 12, 2017

Interesting, need same solution elsewhere, i deal with in these days :)

@aksonov
Copy link
Owner

aksonov commented Aug 14, 2017

It is not supported yet, but probably I could add it.

@pukhalski
Copy link
Author

@aksonov, thanks. It'd be really great since it is a show stopper for us to use it on a real project for now.

@themakerman
Copy link

@aksonov would be grateful if you can do it ASAP as i am using this library on an production APP. Can you please give me any leads on ETA on when you will be able to do it?

@aksonov
Copy link
Owner

aksonov commented Aug 15, 2017 via email

@luco
Copy link
Contributor

luco commented Aug 16, 2017

+1 on this.

aksonov pushed a commit that referenced this issue Aug 23, 2017
@aksonov
Copy link
Owner

aksonov commented Aug 23, 2017

Please check PR #2281

@aksonov
Copy link
Owner

aksonov commented Aug 23, 2017

You must use 'Overlay' custom navigator (check Example project) that will display ALL its children. This way you could add 'backgroundImage' component easily (check Tab #1 overlay from Example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants