onEnter not being executed when using Actions.pop() manually

[rajsuvariya]

Version

Tell us which versions you are using:

• react-native-router-flux v4.0.0-beta.12
• react-native v0.46.3

Expected behavior

When I press "Add" button I am calling Actions.pop() and Actions.refresh({data: this.state.mydata}). In this case, when the previous screen becomes visible onEnter callback should be executed.

Actual behavior

When I press "Add" button I am calling Actions.pop() and Actions.refresh({data: this.state.mydata}). In this case, when the previous screen becomes visible onEnter callback is not being executed. It is being executed when I press back or Android hardware back button from second component.

Steps to reproduce

1. Project with two component
2. Add onEnter and onExit callbacks with console.log() in first component's scene inside router.
3. Add a button to open the second component from first component. (call Actions.openSecondComp())
4. In the second component add a button "Add" and on the press of this button call

    Actions.pop();
    Actions.refresh({data: "Random String"});
   

5. Check console logs. onEnter is not being executed.

[aksonov]

Please check latest master branch. If it still exists, try to reproduce on this repo Example project.

…

On 31 Jul 2017, at 12:28, Raj Suvariya ***@***.***> wrote: Version Tell us which versions you are using: react-native-router-flux v4.0.0-beta.12 react-native v0.46.3 Expected behavior When I press "Add" button I am calling Actions.pop() and Actions.refresh({data: this.state.mydata}). In this case, when the previous screen becomes visible onEnter callback should be executed. Actual behavior When I press "Add" button I am calling Actions.pop() and Actions.refresh({data: this.state.mydata}). In this case, when the previous screen becomes visible onEnter callback is not being executed. It is being executed when I press back or Android hardware back button from second component. Steps to reproduce Project with two component Add onEnter and onExit callbacks with console.log() in first component's scene inside router. Add a button to open the second component from first component. (call Actions.openSecondComp()) In the second component add a button "Add" and on the press of this button call Actions.pop(); Actions.refresh({data: "Random String"}); Check console logs. onEnter is not being executed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2147>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcT9KIISMxjfxQBTlBQrMO2NwutzSks5sTaxqgaJpZM4OoMW7>.

[rajsuvariya]

After taking clone of master even onExit is not working when I open the new screen using Actions.secondComp().

I have added onEnter and onExit props in loginModal in the Example.js in this repo https://github.com/rajsuvariya/react-native-router-flux Please check.

Expected Behavior and test status

1. When login 1 scene is opened console should print 'onEnter' - passed
2. When login 2 button is clicked console should print 'onExit' - failed
3. When pop and refresh is clicked on login 2 console should print 'onEnter' - passed
4. When back is pressed from login 1 console should print 'onExit' - failed

You can verify the same in the gif below

[rajsuvariya]

[aksonov]

So only onExit doesn't work properly, right?

[rajsuvariya]

Yes

[aksonov]

Please check latest master, it should be fixed

[rajsuvariya]

Okay

[rajsuvariya]

No, It isn't fixed yet.

[aksonov]

How did you test it? Are you sure that you are using latest master (not just Example from master) ?

[rajsuvariya]

I am using your example project only and yes I took pull from master not Example project (see the image)

You can find the project here https://github.com/rajsuvariya/react-native-router-flux

[aksonov]

Example uses beta.15 not latest master, that is why I asked you to change RNRF inside Example to latest one.

[rajsuvariya]

I am sorry about that.

But as I am new to open source I don't know how to use the source code directly. Can you please tell me how to do it?

[aksonov]

Ok, please check latest now, I've modified dependencies directly to latest master

[rajsuvariya]

Yes, It's working perfectly. Thanks a lot.