-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for writing bear actions #4
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, here are some suggested changes.
- ``DoNothingAction``: As the name suggests this action does nothing, you can | ||
choose this action when you want to ignore the result. | ||
- ``ShowPatchAction``: This action displays the changes in code suggested by | ||
coala. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bear should be the one suggesting imo
|
||
def run(): | ||
|
||
yield Result(.., actions=[SomeAction()]) # Ignore RSTcheckBear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSTcheckBear having some issues with this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is complaining about invalid syntax, it is because of ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe then you shouldn't ignore, complete the syntax.
4c94e93
to
e53adfd
Compare
You can create this PR in the main coala repo now. |
e53adfd
to
49e3133
Compare
fcebd42
to
b9d72b0
Compare
b9d72b0
to
4d430a2
Compare
This adds a tutorial in the docs which describes how to write actions specific to bears.
4d430a2
to
4460987
Compare
This adds a tutorial which describes how to write
actions specific to bears.