Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualified call to new and cast placement param to void* to ensure placement new #9

Closed
wants to merge 1 commit into from
Closed

qualified call to new and cast placement param to void* to ensure placement new #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions optional.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,15 +377,15 @@ class optional : private OptionalBase<T>
void initialize(Args&&... args) noexcept(noexcept(T(std::forward<Args>(args)...)))
{
assert(!OptionalBase<T>::init_);
new (dataptr()) T(std::forward<Args>(args)...);
::new ((void*)dataptr()) T(std::forward<Args>(args)...);
OptionalBase<T>::init_ = true;
}

template <class U, class... Args>
void initialize(std::initializer_list<U> il, Args&&... args) noexcept(noexcept(T(il, std::forward<Args>(args)...)))
{
assert(!OptionalBase<T>::init_);
new (dataptr()) T(il, std::forward<Args>(args)...);
::new ((void*)dataptr()) T(il, std::forward<Args>(args)...);
OptionalBase<T>::init_ = true;
}

Expand All @@ -399,13 +399,13 @@ class optional : private OptionalBase<T>
optional(const optional& rhs)
: OptionalBase<T>(only_set_initialized, rhs.initialized())
{
if (rhs.initialized()) new (dataptr()) T(*rhs);
if (rhs.initialized()) ::new ((void*)dataptr()) T(*rhs);
}

optional(optional&& rhs) noexcept(std::is_nothrow_move_constructible<T>::value)
: OptionalBase<T>(only_set_initialized, rhs.initialized())
{
if (rhs.initialized()) new (dataptr()) T(std::move(*rhs));
if (rhs.initialized()) ::new ((void*)dataptr()) T(std::move(*rhs));
}

constexpr optional(const T& v) : OptionalBase<T>(v) {}
Expand Down