[16.0] api_sale: some cleanup, fixes and improvements ;-) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uuid field is also removed from the 'Sale' schema since it's a specific field introduced by the use of the sale_cart api. It will be added in the schema in the shopinvader_api_cart
Add 'env' as paramter of the 'to_odoo_domain' method of the 'SaleSearch' schema in order to allow use of the registry to transform provided paramters into a valid domain.
When a schema is processed to get the value provided in the case of a partial update, it's better to always take the value from the properties of the schema instance. The use of the dictionary returned by the 'model_dump' method should be limited to determine if a field has been provided or not in the original json message. This approach allows a better traceability of the use of defined fields and ease code analysis by external tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @sebastienbeau