Mono: reenable tests in System.ComponentModel.Composition.Registratio…

…n that were fixed Closes dotnet#32744
akoeplinger · Jul 1, 2020 · 22c0edf · 22c0edf
1 parent 51094a8
commit 22c0edf
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 15 deletions.
diff --git a/...gistration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs b/...gistration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs
@@ -68,7 +68,6 @@ public FooImporter4(IFoo fooImporter)
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ExportInterfaceWithTypeOf1()
         {
             var ctx = new RegistrationBuilder();
@@ -84,7 +83,6 @@ public void ExportInterfaceWithTypeOf1()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ExportInterfaceWithTypeOf2()
         {
             var ctx = new RegistrationBuilder();
@@ -100,7 +98,6 @@ public void ExportInterfaceWithTypeOf2()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ExportInheritedInterfaceWithImplements1()
         {
             var ctx = new RegistrationBuilder();
@@ -116,7 +113,6 @@ public void ExportInheritedInterfaceWithImplements1()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ExportInheritedInterfaceWithImplements2()
         {
             var ctx = new RegistrationBuilder();

diff --git a/...tration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs b/...tration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs
@@ -48,7 +48,6 @@ public class Importer
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void StandardExportInterfacesShouldWork()
         {
             var builder = new RegistrationBuilder();
@@ -83,7 +82,6 @@ public void StandardExportInterfacesShouldWork()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void StandardExportInterfacesDefaultContractShouldWork()
         {            //Same test as above only using default export builder
             var builder = new RegistrationBuilder();

diff --git a/...ion.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs b/...ion.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs
@@ -416,7 +416,6 @@ public void ExportSelectorNull_ShouldThrowArgumentNull()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void InsideTheLambdaCallGetCustomAttributesShouldSucceed()
         {
             //Same test as above only using default export builder

diff --git a/...Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs b/...Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs
@@ -126,7 +126,6 @@ public ManyConstructorsController(
     public class PartBuilderUnitTests
     {
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ManyConstructorsControllerFindLongestConstructor_ShouldSucceed()
         {
             var ctx = new RegistrationBuilder();
@@ -155,7 +154,6 @@ public void ManyConstructorsControllerFindLongestConstructor_ShouldSucceed()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void ManyConstructorsControllerFindLongestConstructorAndImportByName_ShouldSucceed()
         {
             var ctx = new RegistrationBuilder();
@@ -193,7 +191,6 @@ public void ManyConstructorsControllerFindLongestConstructorAndImportByName_Shou
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void LongestConstructorWithAttribute_ShouldSucceed()
         {
             var ctx = new RegistrationBuilder();
@@ -213,7 +210,6 @@ public void LongestConstructorWithAttribute_ShouldSucceed()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void LongestConstructorShortestWithAttribute_ShouldSucceed()
         {
             var ctx = new RegistrationBuilder();
@@ -233,7 +229,6 @@ public void LongestConstructorShortestWithAttribute_ShouldSucceed()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void AmbiguousConstructorWithAttributeAppliedToOne_ShouldSucceed()
         {
             var ctx = new RegistrationBuilder();
@@ -255,7 +250,6 @@ public void AmbiguousConstructorWithAttributeAppliedToOne_ShouldSucceed()
 
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void AmbiguousConstructor_ShouldFail()
         {
             var ctx = new RegistrationBuilder();

diff --git a/...ests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs b/...ests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs
@@ -22,7 +22,6 @@ public class Factory
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
         public void RegistrationBuilder_WithExportDelegatesShouldNotThrow()
         {
             var rb = new RegistrationBuilder();

diff --git a/...stration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs b/...stration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs
@@ -46,7 +46,7 @@ public DiscoveredCatalog()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)]
         public void ShouldSucceed()
         {
             var rb = new RegistrationBuilder();
-Original file line number
+Diff line change
@@ Expand Up / @@ -416,7 +416,6 @@ public void ExportSelectorNull_ShouldThrowArgumentNull() @@
             }
             [Fact]
-            [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)]
             public void InsideTheLambdaCallGetCustomAttributesShouldSucceed()
             {
                 //Same test as above only using default export builder
@@ Expand Down @@