Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing how columns are being added #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mboudreau
Copy link

It used to be that when columns were being added, they were being pushed into an array that was already on the scope. This causes angular to bind on every single push. Instead, I changed it so that there's only one write to the scope, making it bind only once.

@futhr
Copy link

futhr commented Feb 26, 2015

Hi @mboudreau, just a hint, you change tabs so it hard to see actual changes, now it looks like you refactored everything, I doubt the owner will merge these changes even if its valid.

@Shingaz
Copy link
Contributor

Shingaz commented Oct 9, 2015

With this version, columns are not created again on model change. So you can't do any filtering or ordering on the data passed into the directive.

Edit:
It seems to create duplicates: Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants