fix: Set active CP to UTF-8 on Windows 10 and 11 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This notably allows passing unicode filenames as commandline arguments to the demo utility `bin/base64` without them being mangled in case the unicode filename cannot be represented in the currently active system code page. Note that this only works/takes effect on Windows 10 Version 1903 and later. See-Also: https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
BurningEnlightenment
force-pushed
the
bugfix/bin-utf8-codepage
branch
from
7906129
to
29bb2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notably allows passing unicode filenames as commandline arguments to the demo utility
bin/base64without them being mangled in case the unicode filename cannot be represented in the currently active system code page.Note that this only works/takes effect on Windows 10 Version 1903 and later. This is only integrated with CMake as I don't know how to portably invoke the resource compiler in a Makefile. I also added a test case for the CI.
See-Also: https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
Resolves #138