chore(ci): run static/dynamic analysis #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklomp
reviewed
Oct 23, 2022
test/ci/analysis.sh
Outdated
| MACHINE=$(uname -m) | ||
| uname -a | ||
| gcc --version | ||
| clang --version |
There was a problem hiding this comment.
${CC} --version, no? The rest of the script is compiler agnostic.
There was a problem hiding this comment.
clang is used explicitly in make analyze
I changed gcc by ${CC} and explicitly export CC=gcc
test/ci/analysis.sh
Outdated
| make clean | ||
| make | ||
| make -C test valgrind | ||
| echo "::endgroup::" |
There was a problem hiding this comment.
There's a lot of repetition in this file. I'd be tempted to avoid the copypasting and use a shell loop to enable/disable inline asm:
for ASM_ENABLED in 0 1; do
...
done| continue; | ||
| } | ||
| memcpy(src, &chr[i], chrlen); | ||
| } |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the workflow to run some static / dynamic analysis before running all other jobs.
It updates the unit test in order to get a reproducer for #111