Implement JoinGroup request as first class stream #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Mar 12, 2024
| @@ -62,12 +63,20 @@ public KafkaClientFactory( | |||
| final BindingHandler streamFactory = config.clientConnectionPool() ? connectionPool.streamFactory() : | |||
| context.streamFactory(); | |||
|
|
|||
| final Function<Integer, BindingHandler> streamFactorySupplier = d -> | |||
There was a problem hiding this comment.
Avoid auto-boxing, use IntFunction<BindingHandler> instead, for all references too.
| @@ -362,7 +381,7 @@ public MessageConsumer newStream( | |||
| { | |||
| final long resolvedId = resolved.id; | |||
| final List<KafkaServerConfig> servers = binding.servers(); | |||
| final KafkaSaslConfig sasl = resolveSasl.apply(binding.sasl()); | |||
| final KafkaSaslConfig sasl = resolveSaslSupplier.apply(0).apply(binding.sasl()); | |||
There was a problem hiding this comment.
Please define a constant private static final int NO_REBALANCE_DELAY = 0 and use it here instead of 0.
| @@ -413,6 +432,7 @@ public void onDetached( | |||
|
|
|||
| private MessageConsumer newStream( | |||
| MessageConsumer sender, | |||
| int initialDelay, | |||
There was a problem hiding this comment.
Given the meaning already associated with initial for streams, let's rename initialDelay to rebalanceDelay in this file.
jfallows
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move join group request stream out of coordinator stream and use a separate connection if the group.initial.rebalance.delay.ms > 0 otherwise use the connection pool since there won't be any delay.
Fixes #719