Refactor resolvers to support configuration #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
reviewed
Jan 23, 2024
| String value = resolver.resolve(var); | ||
| return value != null ? value : ""; | ||
| } | ||
|
|
||
| private ExpressionResolver( | ||
| Map<String, ExpressionResolverSpi> resolverSpis) | ||
| private static Resolver instantiate( |
There was a problem hiding this comment.
Since there is only one call to this method can we consolidate
There was a problem hiding this comment.
Yeah, but I'm keeping the pattern consistent in case we can reuse the FactorySpi later.
akrambek
approved these changes
Jan 23, 2024
attilakreiner
added a commit
to attilakreiner/zilla
that referenced
this pull request
Jan 24, 2024
This reverts commit 791b506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor resolvers to support configuration