Sporadic github action build failure fix #522
Conversation
akrambek
changed the title
| @@ -282,6 +289,11 @@ public void close() throws Exception | |||
| } | |||
| } | |||
|
|
|||
| private void drain() | |||
| { | |||
| dispatchers.forEach(d -> d.drain()); | |||
There was a problem hiding this comment.
| dispatchers.forEach(d -> d.drain()); | |
| dispatchers.forEach(DispatchAgent::drain); |
There was a problem hiding this comment.
Also suggest we just inline this, since we don't need a separate Engine.drain() method.
| @@ -90,6 +90,8 @@ read zilla:data.ext ${kafka:matchDataEx() | |||
| .build()} | |||
| read "Hello, world" | |||
|
|
|||
| read notify SENT_ABORT | |||
|
|
|||
There was a problem hiding this comment.
Normally we think of barriers as events that need to be notified because they happened, rather than naming something yet to happen in the future.
So we should rename this to reflect what has already happened here.
Suggest something like RECEIVED_SKIPPED_MESSAGE?
| @@ -73,6 +73,8 @@ write zilla:begin.ext ${kafka:beginEx() | |||
| .build()} | |||
| write flush | |||
|
|
|||
| write await SENT_ABORT | |||
|
|
|||
There was a problem hiding this comment.
Should this be between partition(0, 3, 3, 3) and partition(0, 4, 4, 4) instead?
There was a problem hiding this comment.
Not sure if I understood you correctly, it is between those two message
There was a problem hiding this comment.
I don't mean the beginEx, referring to between the flushEx and the dataEx.
There was a problem hiding this comment.
test are failing if I put between the flushEx and the dataEx.
There was a problem hiding this comment.
Yes, makes sense - the barrier needs to go before the flush.
| @@ -73,6 +73,8 @@ write zilla:begin.ext ${kafka:beginEx() | |||
| .build()} | |||
| write flush | |||
|
|
|||
| write await SENT_ABORT | |||
|
|
|||
There was a problem hiding this comment.
I don't mean the beginEx, referring to between the flushEx and the dataEx.
...la/specs/binding/kafka/streams/application/fetch/isolation.read.committed.aborted/client.rpt
Outdated
Show resolved
Hide resolved
| @@ -73,6 +73,8 @@ write zilla:begin.ext ${kafka:beginEx() | |||
| .build()} | |||
| write flush | |||
|
|
|||
| write await SENT_ABORT | |||
|
|
|||
There was a problem hiding this comment.
Yes, makes sense - the barrier needs to go before the flush.
Description
Fixes #526