Support ALTER STREAM and ALTER TABLE transformation #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jfallows
requested changes
Nov 7, 2024
Comment on lines
25
to
28
| public RisingwaveAlterTopicTemplate() | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
No need for explicit no-args constructor when no other constructors are present, this is implicitly already there.
Same applies to other classes.
Comment on lines
+439
to
+440
| | ALTER opt_column colid opt_set_data TYPE_P typename opt_collate_clause alter_using | ||
| | ALTER opt_column colid alter_generic_options |
There was a problem hiding this comment.
Let's put all the ALTERs together.
Comment on lines
98
to
102
| ObjectNode parentNode = mapper.createObjectNode(); | ||
| parentNode.put("schemaType", "AVRO"); | ||
| parentNode.put("schema", schema.toString()); | ||
|
|
||
| newSchemaJson = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(parentNode); |
There was a problem hiding this comment.
Please use jsonb and eliminate jackson dependency.
jfallows
requested changes
Nov 8, 2024
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.15.2</version> | ||
| <dependency> |
There was a problem hiding this comment.
Suggested change
| <dependency> | |
| <dependency> |
Comment on lines
56
to
63
| if (isNullable) | ||
| { | ||
| return new AvroField(columnName, new Object[]{"null", avroType}); | ||
| } | ||
| else | ||
| { | ||
| return new AvroField(columnName, avroType); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isNullable) | |
| { | |
| return new AvroField(columnName, new Object[]{"null", avroType}); | |
| } | |
| else | |
| { | |
| return new AvroField(columnName, avroType); | |
| } | |
| return isNullable | |
| ? new AvroField(columnName, new Object[]{"null", avroType}) | |
| : new AvroField(columnName, avroType); |
jfallows
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support ALTER STREAM and ALTER TABLE transformation