Raise callback exceptions on communicate() #93

MrMino · 2022-09-02T09:20:59Z

Fixes #92.

Previously, only wait() raised exceptions from the callback thread.
This commit extends this behavior to communicate() in both synchronous
and async flavours.

I'm not 100% sure if I did this the right way, but it seems to work.

Previously, only `wait()` raised exceptions from the callback thread. This commit extends this behavior to `communicate()` in both synchronous and async flavours.

aklajnert

del

for more information, see https://pre-commit.ci

aklajnert · 2022-09-02T16:22:40Z

Thank you for the fix, it does make sense and since all the tests pass, I'll merge it.

Raise callback exceptions on communicate()

da46221

Previously, only `wait()` raised exceptions from the callback thread. This commit extends this behavior to `communicate()` in both synchronous and async flavours.

aklajnert reviewed Sep 2, 2022

View reviewed changes

aklajnert and others added 2 commits September 2, 2022 18:15

Minor adjustment in test.

6fed338

[pre-commit.ci] auto fixes from pre-commit.com hooks

7ce2c24

for more information, see https://pre-commit.ci

aklajnert merged commit 3c2911f into aklajnert:master Sep 2, 2022

MrMino deleted the communicate-side-effects branch September 2, 2022 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise callback exceptions on communicate() #93

Raise callback exceptions on communicate() #93

MrMino commented Sep 2, 2022

aklajnert left a comment •

edited

Loading

aklajnert commented Sep 2, 2022

Raise callback exceptions on communicate() #93

Raise callback exceptions on communicate() #93

Conversation

MrMino commented Sep 2, 2022

aklajnert left a comment • edited Loading

Choose a reason for hiding this comment

aklajnert commented Sep 2, 2022

aklajnert left a comment •

edited

Loading