Make shard lease Release block in PostStop
#7383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Nov 8, 2024
|
|
||
| try | ||
| { | ||
| ReleaseLease().GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Actual fix, we block instead of running Release() in a detached task.
|
|
||
| return; | ||
|
|
||
| async Task ReleaseLease() |
There was a problem hiding this comment.
Code modernization, refactor ContinueWith to internal method
| Log.Debug("{0}: Lease acquired", _typeName); | ||
| TryLoadRememberedEntities(); | ||
| return true; | ||
|
|
||
| case LeaseAcquireResult lar when !lar.Acquired && lar.Reason == null: |
There was a problem hiding this comment.
Code removed and simplified, ILoggingAdaptor.Error can accept null exception, this code is not needed.
| Acquire().PipeTo(self); | ||
| return; | ||
|
|
||
| async Task<LeaseAcquireResult> Acquire() |
There was a problem hiding this comment.
Code modernization, refactor ContinueWith to internal method
Aaronontheweb
added
akka-cluster-sharding
akka-coordination
Aaronontheweb
approved these changes
Nov 8, 2024
| } | ||
| catch | ||
| { | ||
| // no-op, we're shutting down anyway. |
There was a problem hiding this comment.
Might want to log an Exception here just in case
There was a problem hiding this comment.
Ah NM - you do it down below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7379
Changes
ShardcodeRelease()in PostStop instead of doing a detached task. This should be save becauseLeaseis required to have a per operation timeout limit.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):