Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Persistence.Sql.Common: harden SqlJournal and SqlSnapshotStore against initialization failures #7325

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Akka.Persistence.Sql.Common: harden SqlJournal and SqlSnapshotStore against initialization failures #7325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6ccba3
Harden SQL journal in the event of failed initialization
Aaronontheweb Aug 23, 2024
fb39f99
harden snapshot store too
Aaronontheweb Aug 23, 2024
79fa028
Merge branch 'dev' into sql-init-hardening
Arkatufus Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/SqlJournal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,9 @@ protected bool WaitingForInitialization(object message)
return true;
case Status.Failure fail:
Log.Error(fail.Cause, "Failure during {0} initialization.", Self);
Context.Stop(Self);
return true;

// trigger a restart so we have some hope of succeeding in the future even if initialization failed
throw new ApplicationException("Failed to initialize SQL Journal.", fail.Cause);
default:
Stash.Stash();
return true;
Expand Down
5 changes: 3 additions & 2 deletions src/contrib/persistence/Akka.Persistence.Sql.Common/Snapshot/SqlSnapshotStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ private bool WaitingForInitialization(object message)
return true;
case Status.Failure msg:
Log.Error(msg.Cause, "Error during snapshot store initialization");
Context.Stop(Self);
return true;

// trigger a restart so we have some hope of succeeding in the future even if initialization failed
throw new ApplicationException("Failed to initialize SQL SnapshotStore.", msg.Cause);
default:
Stash.Stash();
return true;
Expand Down