-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DData: if lmdb.dir
is null or empty, log a warning and set to default
#7292
DData: if lmdb.dir
is null or empty, log a warning and set to default
#7292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed my changes
@@ -166,7 +171,7 @@ private void Active() | |||
else | |||
{ | |||
if (_pending.Count > 0) | |||
Context.System.Scheduler.ScheduleTellOnce(_writeBehindInterval, Self, WriteBehind.Instance, ActorRefs.NoSender); | |||
Timers.StartSingleTimer("write-behind", WriteBehind.Instance, _writeBehindInterval); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve AK1004
warning
@@ -84,6 +83,12 @@ public LmdbDurableStore(Config config) | |||
|
|||
_path = _config.GetString("dir"); | |||
|
|||
if (string.IsNullOrEmpty(_path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do quick null
check and the log the warning so the user knows that there's something off with their configuration, but then make the system work using its normal defaults afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
DData: if
lmdb.dir
is null or empty, log a warning and set to default. Should address someNullReferenceException
issues that occured when the following HOCON was set:Reported
Exception
:Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):