Add Cluster.Sharding DData backward compatibility wire format mode #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
May 26, 2023
|
The fix was not in the sharding serializer, its in the DData |
|
@Arkatufus is it feasible to unit test this fix? |
|
Well, the target class does not exist in v1.5 binary anymore, testing would require a v1.4 binary protobuf loaded from disk and see if the serializer can deserialize it? |
|
Actually, we can probably test the |
|
Done |
Aaronontheweb
approved these changes
May 29, 2023
| @@ -735,6 +739,11 @@ private Proto.Msg.LWWRegister LWWToProto<T>(ILWWRegister r) | |||
| pLww.State = _ser.OtherMessageToProto(register.Value); | |||
| pLww.Timestamp = register.Timestamp; | |||
| pLww.TypeInfo = GetTypeDescriptor(r.RegisterType); | |||
|
|
|||
| // HACK: Really really ugly hack to make sure that v1.5 DData cluster sharding works with v1.4 | |||
| if(_backwardCompatWireFormat && pLww.TypeInfo.TypeName == "Akka.Cluster.Sharding.ShardCoordinator+CoordinatorState, Akka.Cluster.Sharding") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6704
Changes
akka.cluster.sharding.distributed-data.backward-compatible-wire-formatto allow v1.5 to talk with v1.4NOTES
backward-compatible-wire-formatis set to true,Cluster.Shardingwill not be able to talk to any Cluster.Sharding v1.5.0-v1.5.7, so ifCluster.Shardingwere to talk to v1.4.x, all v1.5 nodes have to be updated to the version with this fix.