Fix ByteString.Copy when requested length is zero
#6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
May 9, 2023
| ConsumerController.SequencedMessage<ZeroLengthSerializer.TestMsg>.FromChunkedMessage(ProducerId, 1 + i, c, i == 0, false, | ||
| producerControllerProbe)).ToList(); | ||
| consumerController.Tell(seqMessages1.First()); | ||
| (await consumerProbe.ExpectMsgAsync<ConsumerController.Delivery<ZeroLengthSerializer.TestMsg>>()).Message.Should().Be(ZeroLengthSerializer.TestMsg.Instance); |
There was a problem hiding this comment.
Reproduction spec would fail here previously and record the same error found in #6749
| /// <summary> | ||
| /// For testing purposes | ||
| /// </summary> | ||
| public sealed class ZeroLengthSerializer : SerializerWithStringManifest |
There was a problem hiding this comment.
Serializer to replicate the error
| @@ -539,6 +539,7 @@ public ByteString Concat(ByteString other) | |||
| /// <returns>TBD</returns> | |||
| public int CopyTo(byte[] buffer, int index, int count) | |||
| { | |||
| if(buffer.Length == 0 && count == 0) return 0; // edge case for no-copy | |||
There was a problem hiding this comment.
Added the same bounds check to all three implementations of the CopyTo method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #6748 - underlying issue was really a
ByteString.Copybug that occurs when the requested length is zero and the buffer length is zero. This is a perfectly legal bounds check, but an unhandled edge case. We now no-op it properly.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):