[Doc] Upgrade to Docfx 2.67.0
#6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `docfx.console`
eaba
commented
May 7, 2023
build.fsx
Outdated
|
|
||
| let args = StringBuilder() | ||
| |> append (docsPath @@ "docfx.json" ) | ||
| //|> append ("--Docfx_Git_Timeout") | ||
| //|> append "30000" | ||
| |> append ("--warningsAsErrors") |
There was a problem hiding this comment.
Unknown option 'Docfx_Git_Timeout'
| @@ -33,7 +33,7 @@ $FakeVersion = "4.63.0" | |||
| $NugetVersion = "5.8.0"; | |||
| $NugetUrl = "https://dist.nuget.org/win-x86-commandline/v$NugetVersion/nuget.exe" | |||
| $ProtobufVersion = "3.21.5" | |||
| $DocfxVersion = "2.59.4" | |||
| $DocfxVersion = "2.67.0" | |||
|
|
|||
| Throw "An error occured while restoring docfx.console from NuGet." | ||
| } | ||
| ##Invoke-Expression "&dotnet new tool-manifest --force" | ||
| dotnet tool install docfx --version $DocfxVersion --tool-path "$ToolPath" --output "$ToolPath" | ||
| } |
|
Local..... |
|
I'd work around this issue and do a local install like how we do for Incrementalist: Lines 105 to 113 in c402cc7 We make zero attempts at updating the existing tool - users have to delete their |
build.ps1
Outdated
| @@ -89,13 +89,11 @@ if (!(Test-Path $ProtobufExePath)) { | |||
| ########################################################################### | |||
|
|
|||
| # Make sure Docfx has been installed. | |||
| $DocfxExePath = Join-Path $ToolPath "docfx.console/tools/docfx.exe" | |||
| $DocfxExePath = Join-Path $ToolPath "docfx.exe" | |||
There was a problem hiding this comment.
need a sub-folder for this
Aaronontheweb
requested changes
May 9, 2023
build.fsx
Outdated
|
|
||
| let args = StringBuilder() | ||
| |> append (docsPath @@ "docfx.json" ) | ||
| |> append ("--warningsAsErrors") | ||
| //|> append ("--Docfx_Git_Timeout") |
There was a problem hiding this comment.
Aren't these the settings we're trying to turn on? And don't we want to keep --warningsAsErrors?
There was a problem hiding this comment.
If I turn it back, is not working. Let me try another way @Aaronontheweb
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
May 15, 2023
This reverts commit 66f348a.
Aaronontheweb
pushed a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6666
Changes
docfx.consoleChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):