[CORE] Dependencies are now moved to Directory.Package.props
#6729
Conversation
eaba
changed the title
Directory.Package.propsDirectory.Package.props
- update `nuget` to `latest`
| @@ -0,0 +1,8 @@ | |||
| <Project> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | |||
There was a problem hiding this comment.
Import Directory.Build.props from src directory
There was a problem hiding this comment.
Why not just have one Directory.Build.props file that governs everything?
There was a problem hiding this comment.
SourceLink support for all Akka.NET projects: we need contrib/Directory.Build.props and I added PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" to fix it
| @@ -0,0 +1,8 @@ | |||
| <Project> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | |||
There was a problem hiding this comment.
Import Directory.Build.props from src directory
There was a problem hiding this comment.
SourceLink support for all Akka.NET projects: we need core/Directory.Build.props and I added PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" to fix it
| Condition="'$(MSBuildProjectExtension)' == '.fsproj' And '$(DisableImplicitFSharpCoreReference)' != 'true' And '$(UpdateImplicitFSharpCoreReference)' != 'false'" | ||
| IsImplicitlyDefined="true" /> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
Added Directory.Build.targets FSharp.Core
There was a problem hiding this comment.
Ah interesting - this is where the NuGet package duplicate warning error has also come from too I suspect. Nice fix.
Changes
Directory.Build.props,Directory.Packages.propsinsidecoredirectoryDirectory.Build.propsinsidecontribdirectoryDirectory.Build.targetsinsidecoredirectoryChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):