Fix StackOverflow exception when NewtonsoftJsonSerializer tries to deserialize a JObject inside an object field
#6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, looks like you reproduced it alright: |
Arkatufus
changed the title
StackOverflow exception when NewtonsoftJsonSerializer tries to deserialize a JObject inside an object field
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Mar 15, 2023
…o deserialize a `JObject` inside an `object` field (akkadotnet#6503) * Reproduction for akkadotnet#6502 * Fix JObject inside object property/field overflow --------- Co-authored-by: Aaron Stannard <[email protected]> (cherry picked from commit 64c6eff)
Aaronontheweb
pushed a commit
that referenced
this pull request
Mar 15, 2023
…rializer` tries to deserialize a `JObject` inside an `object` field (#6522) * Fix `StackOverflow` exception when `NewtonsoftJsonSerializer` tries to deserialize a `JObject` inside an `object` field (#6503) * Reproduction for #6502 * Fix JObject inside object property/field overflow --------- Co-authored-by: Aaron Stannard <[email protected]> (cherry picked from commit 64c6eff) * Remove nullable support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6502
Changes
An
objectproperty was assigned aJObjectinstance, causingStackOverflowinNewtonsoftJsonSerializer. To avoid this, we need to iterate over theJObjectand do our own deserialization.