bug fix: timing regressions in Cluster.JoinAsync methods
#6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the `cluster.seed-node-timeout` property incorrectly in akkadotnet#6033 - that is a "how long did it take from me to hear back from a seed" setting, but we're using it like a "how much time do I have to join the cluster?" setting. Added a function designed to give us at least 20s of leeway.
Aaronontheweb
commented
Feb 28, 2023
src/core/Akka.Cluster/Cluster.cs
Outdated
| CancellationTokenSource timeoutCts = null; | ||
|
|
||
| // if user has a CTS, it is the single source of truth - no second-guessing. | ||
| if (token == default) |
There was a problem hiding this comment.
don't second-guess the user - if they have a CancellationToken, let that be the sole determinant of whether or not the operation succeeded.
There was a problem hiding this comment.
Actually, yes, we need to second guess the user CancellationToken because it has other use other than providing a timeout value and it would change the method behaviour.
src/core/Akka.Cluster/Cluster.cs
Outdated
|
|
||
| RegisterOnMemberUp(() => | ||
| { | ||
| timeoutCts.Dispose(); | ||
| timeoutCts?.Dispose(); |
There was a problem hiding this comment.
We may not have a timeoutCts - null-check it here.
| /// <summary> | ||
| /// Want at least 10-20 seconds of leeway here. | ||
| /// </summary> | ||
| private TimeSpan ComputeJoinTimeLimit() |
There was a problem hiding this comment.
5s, the currently used value, is unrealistically short - 10s-20s is more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We used the
cluster.seed-node-timeoutproperty incorrectly in #6033 - that is a "how long did it take from me to hear back from a seed" setting, but we're using it like a "how much time do I have to join the cluster?" setting.Added a function designed to give us at least 20s of leeway if the user does not provide a
CancellationTokenof their own.If the user does provide their own
CancellationToken, that should be the single source of truth for this operation - second-guessing it without own un-overridable timeout adds zero value.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):