Remove unsafe implicit conversion operators in AtomicBoolean and AtomicReference<T>
#6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this change introduced some hard failures |
Arkatufus
requested changes
Feb 22, 2023
| /// <returns>The result of the conversion.</returns> | ||
| public static implicit operator T(AtomicReference<T> atomicReference) | ||
| { | ||
| return atomicReference.Value; |
There was a problem hiding this comment.
This should also be fine?
Arkatufus
requested changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #6392 - we weren't using these conversion operators in a lot of places and it's better to be explicit about accessing / setting the values on these synchronized types.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):