Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTKIT] Reintroduce old code and mark them obsolete #6420

Merged
merged 4 commits into from
Feb 21, 2023
Merged

[TESTKIT] Reintroduce old code and mark them obsolete #6420

merged 4 commits into from
Feb 21, 2023

Conversation

Arkatufus
Copy link
Contributor

Reintroduce Dispose and AfterAll method to TestKit

Aaronontheweb
Aaronontheweb requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to add IDisposable back and do API approvals

src/contrib/testkits/Akka.TestKit.Xunit2/TestKit.cs Show resolved Hide resolved
Aaronontheweb
Aaronontheweb approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) February 21, 2023 15:00
@Aaronontheweb Aaronontheweb merged commit 46d680f into akkadotnet:dev Feb 21, 2023
@Aaronontheweb Aaronontheweb mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb