Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up build warnings #6418

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

Aaronontheweb
Copy link
Member

Changes

Cleaning up some build warnings.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) February 20, 2023 21:37
@Aaronontheweb
Copy link
Member Author

Akka.Streams.Tests.IO.TcpSpec.Tcp_listen_stream_must_bind_and_unbind_correctly
Failed: Timeout 00:00:03 while waiting for a message of type Akka.Streams.TestKit.TestSubscriber+OnError 
Expected: True
Actual:   False

3 failures - means I probably broke what is being tested.

@Aaronontheweb
Copy link
Member Author

Akka.Streams.Tests.IO.TcpSpec.Tcp_listen_stream_must_bind_and_unbind_correctly
Failed: Timeout 00:00:03 while waiting for a message of type Akka.Streams.TestKit.TestSubscriber+OnError 
Expected: True
Actual:   False

3 failures - means I probably broke what is being tested.

Found the issue here - need to return a Task.Failure<T>(ex) whenever these synchronous operations fail. The async keyword did this automatically for us before.

@Aaronontheweb Aaronontheweb merged commit b570276 into akkadotnet:dev Feb 21, 2023
@Aaronontheweb Aaronontheweb deleted the cleanup-warnings branch February 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant