[PORT #6366] set default PoolRouter SupervisorStrategy to Restart #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Restart (akkadotnet#6366) * close akkadotnet#6295 - set default PoolRouter SupervisorStrategy to Restart * use the `SupervisionStrategy.DefaultStrategy` * Fix unit test * Change unit test to use RoundRobinPool router (cherry-picked from ffd9a9e)
|
Ty! |
| @@ -296,7 +295,7 @@ public async Task ActorTelemetry_must_be_accurate_for_pool_router() | |||
| var telemetry = await subscriber.Ask<TelemetrySubscriber.GetTelemetry>(TelemetrySubscriber.GetTelemetryRequest.Instance); | |||
| // assert that actor start count is still 10 | |||
| Assert.Equal(12, telemetry.ActorCreated); | |||
| Assert.Equal(110, telemetry.ActorRestarted); | |||
| Assert.Equal(10, telemetry.ActorRestarted); | |||
There was a problem hiding this comment.
We will also need to backport this to v1.4 as well
There was a problem hiding this comment.
I wonder why we didn't caught this in the original PR, I guess we missed it amongst the racy unit test noise?
There was a problem hiding this comment.
added the unit test fix in #6376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #6366
Directive.Escalateby default when supervising routees - this causes unintended consequences #6295 - set default PoolRouter SupervisorStrategy to RestartSupervisionStrategy.DefaultStrategy(cherry-picked from ffd9a9e)