Add ReceiveAsync feature to Akka.TestKit TestActorRef #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Nov 30, 2022
| context.CheckReceiveTimeout(); | ||
| } | ||
| else | ||
| { | ||
| context.Self.AsInstanceOf<IInternalActorRef>().SendSystemMessage(new ActorTaskSchedulerMessage(exception, actorScheduler.CurrentMessage)); | ||
| } | ||
|
|
||
| // Used by TestActorRef to intercept async execution result | ||
| if(actorScheduler is IAsyncResultInterceptor interceptor) |
There was a problem hiding this comment.
I'd prefer not to do this on the TaskScheduler that all actors use, but I don't really see a way around it - this is probably the best call we can make in the short run, without redesigining the mailbox system to use Task.
There was a problem hiding this comment.
Yes, other alternatives would require a more radical change to implement, this is the shortest solution I can find without scrambling codes all over the place
| /// </summary> | ||
| /// <param name="message">The message.</param> | ||
| /// <param name="sender">The sender.</param> | ||
| public Task ReceiveAsync(object message, IActorRef sender = null) |
There was a problem hiding this comment.
won't this require API approvals @Arkatufus ?
There was a problem hiding this comment.
It doesn't look like it, at least not locally
|
Yep, did not require API approval |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Dec 1, 2022
Co-authored-by: Aaron Stannard <[email protected]> (cherry picked from commit 5605d83)
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Add ReceiveAsync feature to Akka.TestKit TestActorRef (#6281) Co-authored-by: Aaron Stannard <[email protected]> (cherry picked from commit 5605d83) * Post-merge fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6265
Changes