Fix OldCoordinatorStateMigrationEventAdapter.Manifest #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Oct 14, 2022
| @@ -233,58 +233,73 @@ public override object FromBinary(byte[] bytes, string manifest) | |||
| /// This exception is thrown when the specified <paramref name="o"/> does not have an associated manifest. | |||
| /// </exception> | |||
| /// <returns>The manifest needed for the deserialization of the specified <paramref name="o" />.</returns> | |||
| public static string GetManifest(object o) | |||
There was a problem hiding this comment.
I'd make this internal so it's not part of the public API.
| @@ -17,7 +19,10 @@ internal sealed class OldCoordinatorStateMigrationEventAdapter : IEventAdapter | |||
| { | |||
| public string Manifest(object evt) | |||
| { | |||
| return ""; | |||
| if (evt is IPersistentRepresentation p) | |||
|
@Arkatufus I think you need to re-run API approvals |
Aaronontheweb
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6159
Changes
ClusterShardingMessageSerializer.Manifest()logic to static methodOldCoordinatorStateMigrationEventAdapter.Manifest()forward the proper manifest to the journal