-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend DistributedData Replicator settings with VerboseDebugLogging switch #6080
Conversation
I see that there's a failing test in my PR. Will have to investigate what's failing. |
@object looks like it's the API approval: https://getakka.net/community/contributing/api-changes-compatibility.html#api-change-procedures |
@Aaronontheweb I've fixed API approval failures, it still fails but seems to be unrelated to my changes. Here are some of the errors:
|
Ah, it was still the approval tests - there are three files that all have to be checked in: .NET Framework, .NET Core 3.1, and .NET 6. I also added back an old constructor in order to ensure binary compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Had once test miss its within block by 2 milliseconds - not a big deal. Happens with those timing specs. This looks good - going to merge it in. |
…oseDebugLogging switch (#6084) * Cherry-picked from e3511dc * Fix API verify list Co-authored-by: Vagif Abilov <[email protected]>
Fixes #6074
Changes
This PR extends Akka.DistributedData.ReplicatorSettings with a switch VerboseDebugLogging. This switch is set to false by default to prevent excessive logging of gossip status.
NB! I was not sure of whether I had to update CoreAPISpec.ApproveDistributedData.XXX.verified.txt files. I updated them in a separate commit in case it's needed.