Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial improvements #6057

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

Nicolaidavies
Copy link
Contributor

@Nicolaidavies Nicolaidavies commented Aug 3, 2022

Changes

This PR improves the tutorial by:

  • adding an assertion to tutorial 3. Without this assertion, there is no check of the newly implemented functionality.
  • removing unused arguments that would otherwise stop the code from compiling.
  • including code that is relevant for step 4, that would stop the code from compiling at that point in the tutorial.

I made all the changes while following the tutorial.

CollectionTimeout is referenced in the code, but not shown until the very last step.
@Aaronontheweb
Copy link
Member

Thanks @Nicolaidavies - looks like there's something DocFx isn't happy about in the build logs. I'll check it out today - it's usually something small. We appreciate your contribution!

@Aaronontheweb
Copy link
Member

Actually, looks like it wasn't even a DocFx validation issue - NuGet 503'd during a package restore. I'll just re-run those steps.

@Aaronontheweb Aaronontheweb merged commit 9410a4c into akkadotnet:dev Aug 9, 2022
@Nicolaidavies
Copy link
Contributor Author

Thank you @Aaronontheweb !

@Nicolaidavies Nicolaidavies deleted the tutorial-improvements branch August 10, 2022 04:59
@F0b0s F0b0s mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants