Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Async TestKit] Convert Akka.Streams.Tests to async - FlowFlattenMergeSpec FlowGroupBySpec TimeoutsSpec #5963

Merged
merged 43 commits into from
Jun 20, 2022
Merged

[Async TestKit] Convert Akka.Streams.Tests to async - FlowFlattenMergeSpec FlowGroupBySpec TimeoutsSpec #5963

merged 43 commits into from
Jun 20, 2022

Conversation

Arkatufus
Copy link
Contributor

No description provided.

Arkatufus added 16 commits May 26, 2022 00:57
@Arkatufus
Convert Akka.Streams.Tests to async - FlowFlattenMergeSpec FlowGroupB…
474aba1 
…ySpec TimeoutsSpec
@Arkatufus
Merge branch 'dev' into async_testkit/convert_Akka.Streams.Tests_Dsl.…
b65dab1 
…FlowFlattenMergeSpec
@Arkatufus
Fix FlowGroupBySpec
ec80aea
@Arkatufus
Merge branch 'async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlatte…
fc27a00 
…nMergeSpec' of github.com:Arkatufus/akka.net into async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlattenMergeSpec
@Arkatufus
Fix FlowFlattenMergeSpec
be0334b
@Arkatufus
Fix AssertAllStagesStopped
894d87b
@Arkatufus
Add ShouldThrowWithin Task extension
5072fc0
@Arkatufus
Fix FutureFlattenSourceSpec
a34de2c
@Arkatufus
Revert HubSpec to its original code
9f131e0
@Arkatufus
Merge branch 'dev' into async_testkit/convert_Akka.Streams.Tests_Dsl.…
7c645a6 
…FlowFlattenMergeSpec
@Arkatufus
Add ForEachAsync sink
5e3b8fc
@Arkatufus
Remove extraneous async test functions, causes ambiguous function fin…
8933b4e 
…gerprints
@Arkatufus
Fix specs
b11b147
@Arkatufus
Merge branch 'dev' into async_testkit/convert_Akka.Streams.Tests_Dsl.…
564c08d 
…FlowFlattenMergeSpec
@Arkatufus
Update API verify list
87d4411
@Arkatufus
Merge branch 'async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlatte…
0caf627 
…nMergeSpec' of github.com:Arkatufus/akka.net into async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlattenMergeSpec
@Aaronontheweb
Copy link
Member

@Arkatufus sorry about the merge conflicts :\

Arkatufus added 2 commits June 3, 2022 22:33
@Arkatufus
Merge branch 'dev' into async_testkit/convert_Akka.Streams.Tests_Dsl.…
076f517 
…FlowFlattenMergeSpec

# Conflicts:
#	src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt
#	src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt
#	src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt
@Arkatufus
Merge dev
2b0bec9
@Arkatufus
Copy link
Contributor Author

Its fine, its a simple one to fix.

@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Jun 6, 2022
@Aaronontheweb
Copy link
Member 

System.Exception: Process dotnet test -c Release --no-build --logger:trx --logger:"console;verbosity=normal" --framework netcoreapp3.1 --results-directory "/home/vsts/work/1/s/TestResults" -- -parallel none timed out.
  at [email protected] (System.String message) [0x00001] in <597b0a4fccf1c534a74503834f0a7b59>:0 
  at Fake.ProcessHelper.ExecProcessWithLambdas (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] configProcessStartInfoF, System.TimeSpan timeOut, System.Boolean silent, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] errorF, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] messageF) [0x002a6] in <597b0a4fccf1c534a74503834f0a7b59>:0 
  at [email protected] (System.String project) [0x000a5] in <3681caedf803473288b8104566adacb3>:0 
  at Microsoft.FSharp.Collections.SeqModule.Iterate[T] (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] action, System.Collections.Generic.IEnumerable`1[T] source) [0x0002d] in <5893d081904cf4daa745038381d09358>:0 
  at [email protected] (Microsoft.FSharp.Core.Unit _arg2) [0x00096] in <3681caedf803473288b8104566adacb3>:0 
  at Fake.TargetHelper.runSingleTarget (Fake.TargetHelper+TargetTemplate`1[a] target) [0x0004b] in <597b0a4fccf1c534a74503834f0a7b59>:0 
Starting FinalTarget: KillCreatedProcesses

Test run is timing out.

@Arkatufus
Copy link
Contributor Author

OutputStreamSourceSpec was deadlocking, hope that it is the only one

Aaronontheweb
Aaronontheweb approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending test run results.

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Core.verified.txt Outdated
@@ -1936,6 +1936,7 @@ namespace Akka.Streams.Dsl
public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task<TIn>> First<TIn>() { }
public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task<TIn>> FirstOrDefault<TIn>() { }
public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task> ForEach<TIn>(System.Action<TIn> action) { }
public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task> ForEachAsync<TIn>(int parallelism, System.Func<TIn, System.Threading.Tasks.Task> action) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Streams.TestKit/Utils.cs
throw new Exception($"expected no StreamSupervisor children, but got {children.Aggregate("", (s, @ref) => s + @ref + ", ")}");
{
children.ForEach(c=>c.Tell(StreamSupervisor.PrintDebugDump.Instance));
await Task.Delay(100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need a delay here or is this just compiler ceremony?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometime the stream supervisor got killed faster than the debug print being processed at the end of the test, its allowing for a small leeway for the stream supervisor children to print out a debug.

build.fsx
@@ -250,8 +250,8 @@ Target "RunTests" (fun _ ->
let runSingleProject project =
let arguments =
match (hasTeamCity) with
| true -> (sprintf "test -c Release --no-build --logger:trx --logger:\"console;verbosity=normal\" --framework %s --results-directory \"%s\" -- -parallel none -teamcity" testNetFrameworkVersion outputTests)
| false -> (sprintf "test -c Release --no-build --logger:trx --logger:\"console;verbosity=normal\" --framework %s --results-directory \"%s\" -- -parallel none" testNetFrameworkVersion outputTests)
| true -> (sprintf "test -c Release --blame-crash --blame-hang-timeout 30s --no-build --logger:trx --logger:\"console;verbosity=normal\" --framework %s --results-directory \"%s\" -- -parallel none -teamcity" testNetFrameworkVersion outputTests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well keep this in here for the time being

Arkatufus added 2 commits June 20, 2022 21:52
@Arkatufus
Skip persistence performance test for SqLite for now.
19950ee
@Arkatufus
Merge branch 'async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlatte…
40c17fc 
…nMergeSpec' of github.com:Arkatufus/akka.net into async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlattenMergeSpec
@Aaronontheweb Aaronontheweb merged commit 6c07c56 into akkadotnet:dev Jun 20, 2022
@Arkatufus Arkatufus deleted the async_testkit/convert_Akka.Streams.Tests_Dsl.FlowFlattenMergeSpec branch February 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-streams tests
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb