Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ReceiveWhile Test Methods to Sync over Async #5682

Merged
merged 11 commits into from
Feb 24, 2022
Merged

Change ReceiveWhile Test Methods to Sync over Async #5682

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0f2fec6
Fix the remaining `FishForMessage` `Sync` over `Async` methods
eaba Feb 22, 2022
525bd90
* Changed `ReceiveWhile` to `Sync` over `Async`
eaba Feb 22, 2022
c155a18
Add missing TBD
eaba Feb 22, 2022
b862e73
Create `ReceiveNAsync()`
eaba Feb 22, 2022
579292d
Potential fix for DocFx `StackOverflow` exception
eaba Feb 22, 2022
f8ab3e3
* Changed `FishForMessage` to directly call its `async` version
eaba Feb 23, 2022
c3342cf
Fix build error
eaba Feb 23, 2022
e76060b
Added `CancellationToken` support
eaba Feb 24, 2022
0c6b17b
Merge branch 'feature/async_testkit' into receive_async
eaba Feb 24, 2022
41df413
Changed Receive methods to sync-over-async
eaba Feb 24, 2022
014a417
Add CancellationToken support to InternalReceiveNAsync, remove non-as…
Greg-Petabridge Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/Akka.TestKit.Tests/TestKitBaseTests/ReceiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public async Task FishUntilMessageAsync_should_fail_with_bad_input()
{
var probe = CreateTestProbe("probe");
probe.Ref.Tell(3, TestActor);
Func<Task> func = () => probe.FishUntilMessageAsync<int>(max: TimeSpan.FromMilliseconds(10));
Func<Task> func = () => probe.FishUntilMessageAsync<int>(max: TimeSpan.FromMilliseconds(10)).AsTask();
await func.Should().ThrowAsync<Exception>();
}

Expand Down
2 changes: 2 additions & 0 deletions src/core/Akka.TestKit/Akka.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageReference Include="Nito.AsyncEx.Coordination" Version="5.1.2" />
<PackageReference Include="Nito.AsyncEx.Context" Version="5.1.2" />
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
</ItemGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
Expand Down
Loading