Change ReceiveWhile Test Methods to Sync over Async
#5681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add peek methods into BlockingQueue and TestKitBase * Add Obsolete attribute to BlockingQueue.AddFirst Co-authored-by: Gregorius Soedharmo <[email protected]>
* Modernize Receive function to switch instead of if...else * Remove TestActor DeadLetter logging Co-authored-by: Gregorius Soedharmo <[email protected]>
Co-authored-by: Gregorius Soedharmo <[email protected]>
* Moved the `akka core` configuration page into `modules`` (#5664) * Fix link issue with `xref` (#5666) Co-authored-by: Aaron Stannard <[email protected]> * [Docs]: Fix Metadata Reference (#5668) * Turn on `ProduceReferenceAssembly` * Add `ProduceReferenceAssembly` to `common.props` * Fix build failures in Akka.FSharp * Revert `<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>` added to affected projects because it already exists in `common.props' * Resolved invalid links (#5669) * Check for possible broken documentation by failing on DocFX warning (#5542) * Add --warningsAsErrors flag to DocFX * Add check in AzDo pr validation yaml * Use windows image for docfx test * Fix build script name * disable incremental builds for DocFx Co-authored-by: Aaron Stannard <[email protected]> * Removed internal copy of Nito.AsyncEx.AsyncContext, used the nuget package instead * Add asynchronous queue AsyncQueue to replace BlockingQueue * Remove <inheritdoc> XML doc tags, its causing DocFX crash Co-authored-by: Ebere Abanonu <[email protected]> Co-authored-by: Aaron Stannard <[email protected]> Co-authored-by: Gregorius Soedharmo <[email protected]>
* Switch internal implementation to `async` * Revert changes on `ReceiveOne` methods * replaced `TryPeekAsync` and `TryTakeAsync` with their respective `sync` methods
* Changed to sync over async * * Change Peek methods to sync over async * Create Peek `async` mthods * Change FishForMessage() to sync over async that calls FishForMessageAsync() * Inherit doc from `FishForMessage` * Fix .Wait() returns AggregatedException instead of expected exxception Co-authored-by: Gregorius Soedharmo <[email protected]>
* Created `ReceiveWhileAsync()`
|
Wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part fix for #5617
Changes
ReceiveWhile()to sync overasyncthat callsReceiveWhileAsync()ReceiveWhileAsync()ReceiveN()to sync overasyncthat callsReceiveNAsync()ReceiveNAsync()