Intercept async detached func 5586 #5588
Merged
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Feb 10, 2022
There was a problem hiding this comment.
Need to add a method overload rather than introducing a new optional parameter, per https://getakka.net/community/contributing/api-changes-compatibility.html cc @Arkatufus
…cdude/akka.net into InterceptAsync_detached_func_5586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5586
A brief description of the changes:
The issue is similar to a previous issue (#5537). Here too, the callback ("func" in this case) is not getting awaited.
I modified an interface by adding an optional timeout parameter.
This way, I am forcing the compiler to call the "correct" ExpectAsync version that does await func.
I also modified the interface implementation to reflect the change in the interface.
I left notes for users to see that it is still possible to call ExpectAsync and have func not get awaited.
@Aaronontheweb - you tell me what you think. Obviously, this it not optimal.
I wrote a test to reproduce the issue.
This test failed as expected.
In other words: The issue was getting reproduced as expected.
Then, I fixed the issue.
And then I saw that the test passes as expected.
Compatibility:
[I think so] This change follows the [Akka.NET API Compatibility Guidelines]
[Yes] I have reviewed my own pull request.
[Change in Akka.TestKit Interface change - not reviewed] Changes in public API reviewed, if any.
Included data from after this change here:
Output from visual studio tests:
Akka.TestKit.Tests (net6.0)
Tests in group: 255
Total Duration: 57.2 sec
Outcomes
254 Passed
1 Skipped