Modify MNTR to work with the new MNTR package #5288
Conversation
|
|
||
| static CommandLine() | ||
| { | ||
| Values = new StringDictionary(); | ||
| Initialize(Environment.GetCommandLineArgs()); |
There was a problem hiding this comment.
Have to do this, else net472 tests would fail. It seems like static scope in net472 is different than in netcore, static somehow didn't get propagated from the node runner to the xunit test runner.
| var args = Environment.GetCommandLineArgs(); | ||
| if (args.Length == 0) return false; | ||
| var firstArg = args[0]; | ||
| return firstArg.Contains("Akka.MultiNodeTestRunner") |
There was a problem hiding this comment.
Dropped because we're not using separate executable to run the nodes anymore, and we also have a different namespace/package name that conflicts these. We'll rely on the environment variable to detect whether a test is being run inside MNTR or not.
|
|
||
| public static void Initialize(string[] args) |
There was a problem hiding this comment.
Have to be able to inject arguments from other sources than Environment.GetCommandLineArgs() since we're not relying on CLI args anymore.
| @@ -62,6 +63,7 @@ public void Only_MultiNodeConfig_role_count_used() | |||
|
|
|||
| private static Dictionary<string, List<NodeTest>> DiscoverSpecs() | |||
| { | |||
| Environment.SetEnvironmentVariable(MultiNodeFactAttribute.MultiNodeTestEnvironmentName, "1"); | |||
There was a problem hiding this comment.
"Flag to mark that the current test is being run inside the MNTR" according to @Arkatufus in chat - got it
|
|
||
| static CommandLine() | ||
| { | ||
| Values = new StringDictionary(); | ||
| Initialize(Environment.GetCommandLineArgs()); |
There was a problem hiding this comment.
Ahhh got it - need to defer the Environment.GetCommandLineArgs call until we're ready...
|
This completed a full run of the MNTR and everything ran successfully by the looks of it. LGTM |
No description provided.