Restart(Source|Flow|Sink): Configurable stream restart deadline #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
changed the title
ismaelhamed
changed the title
ismaelhamed
commented
Jul 3, 2021
ismaelhamed
commented
Jul 3, 2021
ismaelhamed
commented
Jul 3, 2021
ismaelhamed
commented
Jul 3, 2021
ismaelhamed
commented
Jul 3, 2021
|
If racy tests are really fixed now, I just need to clean this PR up before it can be merged. |
ismaelhamed
force-pushed
the
configurable-restart-deadline
branch
2 times, most recently
from
f18c4ef to
692d8ab
Compare
|
@Aaronontheweb this PR is ready now |
ismaelhamed
changed the title
ismaelhamed
force-pushed
the
configurable-restart-deadline
branch
from
692d8ab to
752122d
Compare
ismaelhamed
force-pushed
the
configurable-restart-deadline
branch
from
752122d to
a903594
Compare
This was referenced Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #29591
This PR also adds a few missing tests, and attempts to fix the racy ones.