[FLAKY TESTS] Fix several flaky specs #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jun 25, 2021
| @@ -310,7 +310,7 @@ public void OutputStreamSource_must_not_leave_blocked_threads() | |||
| result.ToString().Should().Be("hello"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "Racy")] | |||
Arkatufus
commented
Jun 25, 2021
| @@ -207,7 +207,7 @@ public void Messages_can_be_muted_from_now_on_with_using() | |||
| [Fact] | |||
| public void Make_sure_async_works() | |||
| { | |||
| _testingEventFilter.ForLogLevel(LogLevel).Expect(1, TimeSpan.FromMilliseconds(100), () => | |||
| _testingEventFilter.ForLogLevel(LogLevel).Expect(1, TimeSpan.FromSeconds(2), () => | |||
There was a problem hiding this comment.
Need to add a delay to account for GC
Arkatufus
commented
Jun 25, 2021
| @@ -172,7 +172,7 @@ public void BackoffSupervisor_must_support_default_stopping_strategy_when_using_ | |||
| // TODO: use FilterException | |||
| EventFilter.Exception<TestException>().Expect(1, () => | |||
| { | |||
| var supervisor = Create(OnStopOptions().WithDefaultStoppingStrategy()); | |||
| var supervisor = Create(OnStopOptions().WithDefaultStoppingStrategy().WithManualReset()); | |||
There was a problem hiding this comment.
If a GC happened, supervisor might be delayed and auto reset might kick in, resetting the restart counter to 0, failing the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.