Fixed QueueSource PostStop and added a missing test case #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
May 1, 2021
| @@ -153,7 +153,7 @@ public void QueueSink_should_timeout_future_when_stream_cannot_provide_data() | |||
| }, _materializer); | |||
| } | |||
|
|
|||
| [Fact(Skip = "Racy, see https://github.com/akkadotnet/akka.net/pull/4424#issuecomment-632284459")] | |||
| [Fact] | |||
There was a problem hiding this comment.
Let's see if this was fixed too
ismaelhamed
commented
May 1, 2021
| t.Exception.InnerException.Should().BeOfType<IllegalStateException>(); | ||
| }, TaskContinuationOptions.OnlyOnFaulted).Wait(); | ||
| var exception = Record.ExceptionAsync(async () => await queue.PullAsync()).Result; | ||
| exception.Should().BeOfType<StreamDetachedException>(); |
There was a problem hiding this comment.
Using XUnit API to catch the exception and unwrap. Also, this should always run, not just on OnlyOnFaulted, to make sure we catch regressions.
…on when stream already completed
ismaelhamed
force-pushed
the
fix-queuesourcespec
branch
from
331cd3a to
437a9b4
Compare
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #23151 and #23509